Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2777 - Hide popup when initially loaded #2782

Merged
merged 2 commits into from
Sep 3, 2024
Merged

2777 - Hide popup when initially loaded #2782

merged 2 commits into from
Sep 3, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

The popup was actually visible in its in initial state. This fixes it

Related github/jira issue (required):
Fixes #2777

Steps necessary to review your pull request (required):

  • go to http://localhost:4300/ids-lookup/example.html
  • notice no more scrollbar due to the popup taking up space
  • retest examples that use popup (tooltip, modal, action panel, menu button, popup, popupmenu) examples for any issues

Included in this Pull Request:

  • A note to the change log.

jbrcna
jbrcna previously approved these changes Sep 2, 2024
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image

glenlieorillo
glenlieorillo previously approved these changes Sep 2, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookup
image

image

Tooltip
image

image

Modal
image

image

Action Panel
image

image

Menu Button
image

image

Popup
image

image

Popup Menu
image

image

@tmcconechy tmcconechy dismissed stale reviews from glenlieorillo and jbrcna via 3749fc5 September 3, 2024 13:11
@tmcconechy tmcconechy merged commit e667a7b into main Sep 3, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 2777-lookup-space branch September 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsLookup: Along with autocomplete option occupies extra space that leads to scroll bar
3 participants